Mifare Ultralight - Shadowmode#251
Merged
GameTec-live merged 2 commits intoRfidResearchGroup:mainfrom Apr 21, 2025
Merged
Conversation
|
You are welcome to add an entry to the CHANGELOG.md as well |
Built artifacts for commit 8a6481dFirmwareClient |
turbocool3r
reviewed
Apr 21, 2025
| keys.add(bytes.fromhex(key)) | ||
| else: # in case of another format, a conversion is needed | ||
| print(f' - {CR}Key should in hex[12] format, invalid key is ignored{C0}, key = "{key}"') | ||
| continue |
Contributor
There was a problem hiding this comment.
Maybe this could go in a separate PR?
Contributor
There was a problem hiding this comment.
I see this changed in a separate commit. Squashing these would be nice.
turbocool3r
approved these changes
Apr 21, 2025
Contributor
turbocool3r
left a comment
turbocool3r
left a comment
There was a problem hiding this comment.
Besides the small unrelated change to dictionary parsing I very much like these changes.
GameTec-live
approved these changes
Apr 21, 2025
Contributor
|
Just for the record, I tested this and all the write modes worked correctly with and without going into sleep mode. I've also tested that the cli commands correctly handle the situation when firmware doesn't support the API commands. |
Contributor
Author
|
Thanks a lot for your review @turbocool3r :) |
Contributor
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding Shadow mode on Ultralight based on the existing implementation for Classic 1k.